Merged
Conversation
mmitche
approved these changes
Apr 21, 2021
2 tasks
Member
|
A test would be useful to protect this from regressing again. |
ViktorHofer
approved these changes
Apr 21, 2021
michellemcdaniel
approved these changes
Apr 21, 2021
Member
Author
|
I am adding some more test as a part of publishing here-> #7190 I will think of more test to cover symbol publishing as part of this exercise. |
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
riarenas
approved these changes
Apr 21, 2021
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
riarenas
reviewed
Apr 21, 2021
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
riarenas
approved these changes
Apr 21, 2021
michellemcdaniel
approved these changes
Apr 21, 2021
hoyosjs
approved these changes
Apr 21, 2021
Member
Author
|
verified it against general-testing-internal channel https://dnceng.visualstudio.com/internal/_build/results?buildId=1100514&view=results and @hoyosjs confirmed he can download the files. Symweb needs corpnet to download the files. |
Member
|
thanks @epananth ! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
Issue -> https://github.com/dotnet/core-eng/issues/12893
Test build -> https://dnceng.visualstudio.com/internal/_build/results?buildId=1100201&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a