Add hook to exclude harvested supported frameworks#7272
Merged
Conversation
For packages which drop assets intentionally, there's currently no hook to remove supported frameworks that are determined by the harvested package. Adding that to be able to drop assets in the packages without disabling the whole support validation.
Anipik
approved these changes
Apr 21, 2021
ericstj
approved these changes
Apr 21, 2021
Member
Author
|
@dotnet/dnceng can someone please merge the PR? The leg is continuing to time out. I submitted #7277 to increase the time out. The code path touched isn't exercised in CI and most definitely not on Android. |
Member
|
Shenanigans performed. |
Member
Author
|
Thanks a lot Matt 👍 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For packages which drop assets intentionally, there's currently no hook to remove supported frameworks that are determined by the harvested package. Adding that to be able to drop assets in the packages without disabling the whole support validation.