Emit the hostArchitectures attribute when building the macOS bundle.#7232
Emit the hostArchitectures attribute when building the macOS bundle.#7232jkoritzinsky merged 3 commits intomainfrom
Conversation
sdmaclea
left a comment
There was a problem hiding this comment.
That change looks almost correct. The attribute is hostArchitectures, note the final s
I don't know how to check this works correctly, so only visually inspected.
I also don't know how to test this on my machine easily. Since Rosetta is already installed. I guess I would have to figure out how to remove it....
I think we will eventually want to set os-version min to 11.3 for Apple Silicon, because 11.2 and earlier are horribly unstable.
|
The best way to test this would be to build Arcade locally and set the |
|
I built this on my M1, the generated <options customize="never" require-scripts="false" hostArchitectures="arm64"/>
<welcome file="welcome.html" mime-type="text/html"/>
<conclusion file="conclusion.html" mime-type="text/html"/>
<volume-check>
<allowed-os-versions>
<os-version min="10.13"/>
</allowed-os-versions>
</volume-check>It even worked when there was already a |
|
Apple has not provided a published mechanism to uninstall Rosetta 2, so I cannot check this actually fixes the issue on my M1. |
|
It should not overwrite if the attribute is already present. It leaves the attribute as is. |
|
As the distribution file looks correct, we'll go with this until we know we need something else. |
@sdmaclea can you validate that this change allows us to build an ARM64 distribution bundle on non Big Sur MacOS machines?
Contributes to dotnet/runtime#48388
Fixes #7233