Add ASP.NET Core runtime version test#7227
Conversation
|
Forgot to make it only run on Windows lol. One sec. |
MattGal
left a comment
There was a problem hiding this comment.
LGTM, was going to make the windows comment but you beat me to it.
premun
left a comment
There was a problem hiding this comment.
Looks good!
I can see one possible way this could fail - if someone went and changed the the type of .NET in the unit tests from SDK to ASP.NET Runtime. Then we would be testing ASPNET vs ASPNET and it would always succeed. But I guess other parts of the unit tests would fail and this won't really happen.
| <Project> | ||
| <PropertyGroup> | ||
| <IncludeDotNetCli Condition=" '$(IncludeDotNetCli)' != 'true' ">false</IncludeDotNetCli> | ||
| <AspNetCoreRuntimeVersion>6.0.0-preview.2.21154.6</AspNetCoreRuntimeVersion> |
There was a problem hiding this comment.
Can you also please use this property inside XHarnessRunner.targets?
There was a problem hiding this comment.
@premun Check out the latest push and see if you think this will work.
There was a problem hiding this comment.
@jonfortescue it didn't work out of the box? without pulling the property in its own file?
I think the whole DotNetCli is included for Helix SDK already
There was a problem hiding this comment.
I am meaning to say - did you just try using the property without any other changes?
src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/XHarnessRunner.targets
Outdated
Show resolved
Hide resolved
|
@jonfortescue seems like
If you went few commits back and didn't pull the property in its own new file, and just define it in I might be wrong but can you verify that please? |
|
@premun oooh neat. let's test it. |
src/Microsoft.DotNet.Helix/Sdk/tools/dotnet-cli/DotNetCli.props
Outdated
Show resolved
Hide resolved
premun
left a comment
There was a problem hiding this comment.
Nice, should work well!
Also we should probably move to .NET 6.0 preview 3 in Arcade
Closes #7022.
Adds a test to verify that the hardcoded version of the ASP.NET Core runtime matches the .NET SDK version.
Example console logs (from UnitTests.proj): Passing
Example console logs (from testing proj): Passing, Failing due to mismatch, Failing due to invalid version number
To double check: