Remove TargetPlatform from Tfm only for frameworks older than net5.0#6479
Merged
Anipik merged 4 commits intodotnet:masterfrom Nov 3, 2020
Anipik:moniker
Merged
Remove TargetPlatform from Tfm only for frameworks older than net5.0#6479Anipik merged 4 commits intodotnet:masterfrom Anipik:moniker
Anipik merged 4 commits intodotnet:masterfrom
Anipik:moniker
Conversation
Member
|
Add code comments to describe the why and the what? |
ViktorHofer
reviewed
Oct 28, 2020
...d.Tasks.TargetFramework.Sdk/src/build/Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.props
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ViktorHofer @safern @ericstj this is ready for merge, can you guys take a look ? |
ericstj
reviewed
Nov 2, 2020
...d.Tasks.TargetFramework.Sdk/src/build/Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.props
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
ViktorHofer
approved these changes
Nov 3, 2020
Member
ViktorHofer
left a comment
There was a problem hiding this comment.
Let's get this in as soon as possible as you already updated the Windows-NT platform to windows in dotnet/runtime. I'm sure something is already broken because of this, hence let's get this in fast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.