Port Arcade PR 6315 to release/3.x#6332
Merged
MattGal merged 1 commit intodotnet:release/3.xfrom Oct 6, 2020
Merged
Conversation
… failure can slow down the API
mmitche
approved these changes
Oct 6, 2020
Member
Author
|
As I did for master, I created #6333 is the same changes rigged to fail so this code actually gets exercised before merge. Update: Failed as expected, will merge after build is green. |
markwilkie
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port a change to prevent accessing all possible helix work items from a 100% failure scenario in parallel. This became necessary as Helix API now has a 90s gateway timeout that we're not likely to increase. See https://github.com/dotnet/core-eng/issues/11037 for more details.
Customer Impact
All Helix API users (automated and otherwise) may experience errors / slowdown while a run without this change is being finished in AzDO.
Regression
No
Risk
Minor, low risk Change, validated by linked PR that intentionally fails.
Workarounds
None for users. We're still looking at how best to deal with this from the Helix API (such as changing the files API to not use SQL connections, increasing instances, etc)