Remove sleet from 3.x release#6059
Merged
mmitche merged 1 commit intodotnet:release/3.xfrom Sep 9, 2020
Merged
Conversation
Sleet has a versioning problem with the dotnet SDK. Sleet isn't necessary any longer, and it's easier to remove it than to fix it.
Contributor
|
Looks good to me, could you go through the song and dance of setting up an internal build so that we can see it skip sleet? |
Contributor
|
Build using an arcade produced with this change that didn't publish to sleet, and therefore didn't fail with 3.1: https://dnceng.visualstudio.com/internal/_build/results?buildId=791069&view=logs&s=43bc2acf-84b9-56c3-9391-690a0fcfcd12&j=f7bb3748-e35d-53de-9dd7-460ecd2014d6 |
riarenas
approved these changes
Aug 27, 2020
mmitche
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sleet has a versioning problem with the dotnet SDK.
Sleet isn't necessary any longer, and it's easier to remove
it than to fix it.