[release/3.x] Update darc-init.sh to match master version#6055
Merged
mmitche merged 3 commits intodotnet:release/3.xfrom Aug 27, 2020
Merged
[release/3.x] Update darc-init.sh to match master version#6055mmitche merged 3 commits intodotnet:release/3.xfrom
mmitche merged 3 commits intodotnet:release/3.xfrom
Conversation
dagood
approved these changes
Aug 27, 2020
Member
dagood
left a comment
There was a problem hiding this comment.
Added template to the description from https://github.com/dotnet/arcade/blob/master/Documentation/Policy/AskModeTellModeTemplate.md and filled in a few things, @dseefeld PTAL to make sure it's ok.
mmitche
reviewed
Aug 27, 2020
mmitche
approved these changes
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#5534 updated
darc-init.ps1to match master. This PR adds the.shversion as well so source-build can use it.Customer Impact
Source-build can't use
eng/common/darc-init.shin 3.x without this change.Regression
No
Risk
None (copied from #5534)
Workarounds
Source-build can maintain a fork/copy of the script. This has maintenance cost and it will likely not keep up to date with changes in dotnet/arcade.