Don't import Nuget.targets files that aren't there#5754
Merged
MattGal merged 1 commit intodotnet:release/3.xfrom Jul 7, 2020
Merged
Don't import Nuget.targets files that aren't there#5754MattGal merged 1 commit intodotnet:release/3.xfrom
MattGal merged 1 commit intodotnet:release/3.xfrom
Conversation
…net#5753) release/3.x version. Files have significantly diverged so not a direct cherry-pick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From #5379, change merged in master; just a check for file existence before including.
This is the release/3.x version. Files have significantly diverged so not a direct cherry-pick.
Customer Impact
Certain build environments where the assumptions made w.r.t. file location here will fail to build
Regression
No
Risk
Very low : Checking existence of a file before using it.
Workarounds
Customers hitting this would need to either override MSBuild props/targets or change build agent(s) used