Support signing tarballs containing hardlinks#16514
Merged
MichaelSimons merged 2 commits intodotnet:mainfrom Feb 10, 2026
Merged
Support signing tarballs containing hardlinks#16514MichaelSimons merged 2 commits intodotnet:mainfrom
MichaelSimons merged 2 commits intodotnet:mainfrom
Conversation
ellahathaway
approved these changes
Feb 9, 2026
Member
ellahathaway
left a comment
There was a problem hiding this comment.
LGTM with one small comment
| UseShellExecute = false, | ||
| RedirectStandardError = true | ||
| }); | ||
| process.WaitForExit(); |
Member
There was a problem hiding this comment.
process.WaitForExit() can block indefinitely. Consider adding a timeout here (and handling the timeout case) to avoid a potential hang
Member
Author
There was a problem hiding this comment.
Good point. I see this is an existing problem in several places within the SignTool. I refactored this code to use the existing RunExternalProcess utility method in 879b3b6. This at least provides better logging but doesn't address the hang issue you noted. I logged a separate issue to address hangs throughout SignTool - #16517
ellahathaway
previously approved these changes
Feb 9, 2026
Member
ellahathaway
left a comment
There was a problem hiding this comment.
LGTM with one small comment
ellahathaway
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for #16484 until dotnet/runtime#74404 is resolved. The runtime work to support hardlinks is actively being worked on but the scope expanded a bit and I would like to get unblocked now. I will revert the code changes when the runtime fix is in place and flows. The new test is valuable long term.