Skip to content

Add DO-NOT-UNPACK support to SignCheck#16485

Merged
ellahathaway merged 1 commit intodotnet:mainfrom
ellahathaway:signcheck-do-not-unpack
Jan 30, 2026
Merged

Add DO-NOT-UNPACK support to SignCheck#16485
ellahathaway merged 1 commit intodotnet:mainfrom
ellahathaway:signcheck-do-not-unpack

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Jan 28, 2026 •
edited
Loading

Related to #16370
Needed for dotnet/dotnet#4560

This PR allows files to skip unpacking in SignCheck

Exclusion in SignCheckExclusionsFile.txt:

;; ## Do Not Unpack ##
dotnet-source-*.tar.gz;; DO-NOT-UNPACK

SignCheck output:

Processing exclusions list in /workspace/dotnet/eng/SignCheckExclusionsFile.txt
Starting execution of SignCheck.
Skipping archive extraction on /workspace/temp/artifacts/assets/Release/source-build/dotnet-source-11.0.100-preview.1.26078.110.tar.gz.

Results

No signing issues found
Total Time: 00:00:00.0529113
Total Files: 1, Signed: 0, Unsigned: 0, Skipped: 1, Excluded: 0, Skipped & Excluded: 0, Not Unpacked: 1

@ellahathaway ellahathaway requested a review from mmitche January 28, 2026 23:23
@ellahathaway
Copy link
Member Author

ellahathaway commented Jan 30, 2026

@mmitche - friendly ping for a review. Thanks :)

@ellahathaway ellahathaway merged commit b7be18a into dotnet:main Jan 30, 2026
9 checks passed
@ellahathaway
Copy link
Member Author

ellahathaway commented Jan 31, 2026

/backport to release/10.0

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

Started backporting to release/10.0 (link to workflow run)

@github-actions github-actions bot mentioned this pull request Jan 31, 2026
Merged
This was referenced Jan 31, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitche mmitche mmitche approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ellahathaway @mmitche