Skip to content

Fix reading container contents when DoNotUnpack is set#16478

Merged
ellahathaway merged 1 commit intodotnet:mainfrom
ellahathaway:fix-do-not-unpack
Jan 27, 2026
Merged

Fix reading container contents when DoNotUnpack is set#16478
ellahathaway merged 1 commit intodotnet:mainfrom
ellahathaway:fix-do-not-unpack

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Jan 27, 2026

Was encountering error MSB4018: System.Collections.Generic.KeyNotFoundException: The given key 'Microsoft.DotNet.SignTool.SignedFileContentKey' was not present in the dictionary while trying to implement https://github.com/dotnet/release/issues/1416 (signing the source asset).

I verified that the changes in this PR fix the errors and allow the source asset to skip unpacking.

@ellahathaway ellahathaway changed the title Fix trying to read container contents when DoNotUnpack is set Fix reading container contents when DoNotUnpack is set Jan 27, 2026
@ellahathaway ellahathaway marked this pull request as ready for review January 27, 2026 19:07
@ellahathaway ellahathaway requested a review from mmitche January 27, 2026 19:11
@ellahathaway ellahathaway enabled auto-merge (squash) January 27, 2026 19:16
@ellahathaway ellahathaway merged commit 2b00f25 into dotnet:main Jan 27, 2026
8 of 9 checks passed
@ellahathaway
Copy link
Member Author

/backport release/10.0

@akoeplinger
Copy link
Member

/backport to release/10.0

@github-actions
Copy link
Contributor

Started backporting to release/10.0 (link to workflow run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants