Enable tools.ps1 find VS logic to work even if VS is not in global.json#16401
Merged
nagilson merged 2 commits intorelease/9.0from Dec 11, 2025
Merged
Enable tools.ps1 find VS logic to work even if VS is not in global.json#16401nagilson merged 2 commits intorelease/9.0from
nagilson merged 2 commits intorelease/9.0from
Conversation
Because 17.14 went stable, we needed a way to run vswhere, find the VS node, and enable preview SDKs. Noah found a way to do this but he had to modify tools.ps1 because the SDK repo didn't have a VS node in our global.json https://github.com/dotnet/sdk/pull/51558/files#diff-72b8f8e899b94872c6ead31fd06ec109da15bcb9ad2af6e78103d6763a31c637 Porting his change here to see if folks want this centrally. Alternatively, I'm trying adding the vs node to global.json to see if it unblocks us.
Member
Author
|
Thanks! Are we in a state where we can deploy this right now to both branches or are they closed? |
Member
|
@nagilson would you mind porting this to main and release/10.0 as well? arcade doesn't have inter-branch merging. |
Member
Author
|
@copilot Can you please port this to main and release/10.0? |
Member
Author
|
/backport to release/10.0 |
Member
Author
|
/backport to main |
Contributor
|
Started backporting to |
Contributor
|
Started backporting to |
This was referenced Dec 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
q.t. from @marcpopMSFT in #16313
https://github.com/dotnet/sdk/pull/51558/files#diff-72b8f8e899b94872c6ead31fd06ec109da15bcb9ad2af6e78103d6763a31c637
We discussed this in #16313 and had decided to close it. But really, this is a small bug fix into the script because it enables finding VS without needing a global.json node. The Arcade wide machine fix didn't seem to work. But regardless of that, we think this subset, which enables the broader change in dotnet/sdk#51558, should be done to improve the code.