Skip to content

Support internal feeds for .NET 10#16121

Merged
mmitche merged 2 commits intomainfrom
copilot/fix-16120
Sep 17, 2025
Merged

Support internal feeds for .NET 10#16121
mmitche merged 2 commits intomainfrom
copilot/fix-16120

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 9, 2025

Updates the eng/common/SetupNugetSources.* scripts to support dotnet10 internal feeds by adding '10' to the version arrays in both PowerShell and Bash implementations.

Changes Made

  • SetupNugetSources.ps1: Added '10' to $dotnetVersions array (line 160)
  • SetupNugetSources.sh: Added '10' to DotNetVersions array (line 102)

Behavior

When the scripts detect dotnet10 or dotnet10-transport feeds in a NuGet.config file, they now automatically add the corresponding internal feeds:

  • dotnet10-internal
  • dotnet10-internal-transport

This follows the existing pattern used for .NET versions 5-9 and ensures builds that depend on internal .NET 10 packages can access the necessary package sources.

Testing

Validated that both scripts correctly:

  • Detect dotnet10 public feeds in NuGet.config
  • Add corresponding internal feeds with proper URLs
  • Maintain existing functionality for dotnet5-9
  • Work with the repository's actual NuGet.config

Fixes #16120.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mmitche <8725170+mmitche@users.noreply.github.com>
Copilot AI changed the title [WIP] Support internal feeds for .NET 10 Support internal feeds for .NET 10 Sep 9, 2025
Copilot AI requested a review from mmitche September 9, 2025 22:52
@akoeplinger akoeplinger marked this pull request as ready for review September 10, 2025 12:57
@mmitche mmitche enabled auto-merge (squash) September 10, 2025 15:17
@mmitche
Copy link
Copy Markdown
Member

mmitche commented Sep 10, 2025

/backport to release/10.0

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/10.0: https://github.com/dotnet/arcade/actions/runs/17618455021

@mmitche mmitche merged commit 9f7b1c9 into main Sep 17, 2025
10 checks passed
@mmitche mmitche deleted the copilot/fix-16120 branch September 17, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support internal feeds for .NET 10

4 participants