[release/8.0] Add ability to opt-out of ESRP service connection use.#16007
Merged
mmitche merged 1 commit intodotnet:release/8.0from Jul 28, 2025
Merged
[release/8.0] Add ability to opt-out of ESRP service connection use.#16007mmitche merged 1 commit intodotnet:release/8.0from
mmitche merged 1 commit intodotnet:release/8.0from
Conversation
I chose to use microbuildUseESRP rather than microbuildSignType because I don't want users to confuse use of the parameter with setting signing to test signing or real signing. _SignType is so prolific that it's hard to imagine getting rid of it at this point. So I chose just to have a parameter that indicates whether the service connection should be used. A user would pass false in test signing cases. This could be passed based on the value of _SignType if it's defined in the same file.
YuliiaKovalova
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose to use microbuildUseESRP rather than microbuildSignType because I don't want users to confuse use of the parameter with setting signing to test signing or real signing. _SignType is so prolific that it's hard to imagine getting rid of it at this point. So I chose just to have a parameter that indicates whether the service connection should be used. A user would pass false in test signing cases. This could be passed based on the value of _SignType if it's defined in the same file.
To double check: