WiX v5 for Microsoft.DotNet.Build.Tasks.Installers #15933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <!-- | ||
| Locate WiX tools. | ||
| --> | ||
| <Target Name="_AcquireWix"> |
Member
Author
There was a problem hiding this comment.
Another option would be to add Microsoft.WixToolset.* as NuGet dependencies for this package. But this would mean v3 would also have them as dependencies.
joeloff
reviewed
Aug 13, 2025
src/Microsoft.DotNet.Build.Tasks.Installers/build/resources/DotNetLogo_124x.png
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Aug 13, 2025
src/Microsoft.DotNet.Build.Tasks.Installers/build/bundle.targets
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Aug 13, 2025
src/Microsoft.DotNet.Build.Tasks.Installers/build/wix5/bundle/bundle.wxs
Show resolved
Hide resolved
joeloff
reviewed
Aug 13, 2025
| <Variable Name="PRODUCT_NAME" Type="string" Value="$(var.ProductName)" bal:Overridable="no" /> | ||
| <Variable Name="LINK_PREREQ_PAGE" Type="string" Value="https://go.microsoft.com/fwlink/?linkid=846817" bal:Overridable="no" /> | ||
|
|
||
| <?ifdef WixThemeFile ?> |
Member
There was a problem hiding this comment.
Is this needed or used? The theme file is specified as part of BoostrapperApplication@ThemeFile
Member
Author
There was a problem hiding this comment.
I think this is used for HyperlinkLicense. This file is conditionally generated based on whether there are any WixThemeVariable items
and ASP.NET Core seems to have them: https://github.com/dotnet/aspnetcore/blob/9e341eded50d7b08cd8d83749a4eb1978dd4cfb0/src/Framework/App.Runtime/bundle/aspnetcore-runtime-bundle.bundleproj#L42-L47
joeloff
reviewed
Aug 13, 2025
src/Microsoft.DotNet.Build.Tasks.Installers/build/wix5/bundle/bundle.wxs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Installers/build/wix5/wix.targets
Outdated
Show resolved
Hide resolved
Member
|
Pushed the following fixes with 1d32c84
|
joeloff
reviewed
Aug 20, 2025
src/Microsoft.DotNet.Build.Tasks.Installers/build/wix5/variables.wxi
Outdated
Show resolved
Hide resolved
joeloff
previously approved these changes
Aug 20, 2025
joeloff
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wix buildHarvestDirectorytaskdotnet/runtime PR that will consume these changes: dotnet/runtime#117010
Contributes to dotnet/runtime#116878