Skip to content

Do not sign .js files by default#15760

Merged
ellahathaway merged 3 commits intodotnet:mainfrom
ellahathaway:remove-default-js-signing
Apr 22, 2025
Merged

Do not sign .js files by default#15760
ellahathaway merged 3 commits intodotnet:mainfrom
ellahathaway:remove-default-js-signing

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Apr 18, 2025

Example output:

/repos/arcade-validation# ./build.sh -sign
  /root/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.29501.1/tools/Tools.proj                Restore (0.5s)
Restore complete (0.5s)
  Validation net10.0 succeeded (0.1s) → artifacts/bin/Validation/Debug/net10.0/Validation.dll
  Validation.Tests succeeded (0.5s) → artifacts/bin/Validation.Tests/Debug/net10.0/Validation.Tests.dll
  Sign succeeded (0.3s)
    /root/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.29501.1/tools/Sign.proj(76,5): error : Skipping file '/root/repos/arcade-validation/artifacts/packages/Debug/NonShipping/blazor.webview.js' because .js files are no longer signed by default. To disable this warning, please explicitly define the FileExtensionSignInfo for the .js extension or set the MSBuild property 'NoSignJS' to 'true'.

Build failed with 1 error(s) in 2.4s
Build failed with exit code 1. Check errors above.

mmitche
mmitche reviewed Apr 21, 2025
View reviewed changes
src/Microsoft.DotNet.SignTool/src/Configuration.cs
{
_log.LogWarning($"Skipping file '{file.FullPath}' because .js files are no longer signed by default. " +
"To disable this warning, please explicitly define the FileExtensionSignInfo for the .js extension " +
"or set the MSBuild property 'NoSignJS' to 'true'.");
Copy link
Member

@mmitche mmitche Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue to remove this breaking change and make NoSignJS the default, and link it in a comment here?

Ideally we won't leave this option around long.

Copy link
Member Author

@ellahathaway ellahathaway Apr 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - linked the issue in 2da35cb

@ellahathaway ellahathaway mentioned this pull request Apr 21, 2025
Open
@ellahathaway
Copy link
Member Author

ellahathaway commented Apr 21, 2025

Looks like the tests had failures. I'll address those now

@ellahathaway ellahathaway requested a review from mmitche April 21, 2025 21:19
@ellahathaway ellahathaway merged commit 93536ed into dotnet:main Apr 22, 2025
11 checks passed
@ellahathaway ellahathaway deleted the remove-default-js-signing branch April 22, 2025 15:10
@ellahathaway ellahathaway mentioned this pull request Apr 22, 2025
Merged
This was referenced Nov 17, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitche mmitche mmitche approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ellahathaway @mmitche