Fix version comparison in install-debs.py#15376
Merged
akoeplinger merged 1 commit intodotnet:mainfrom Jan 5, 2025
Merged
Conversation
Member
Author
|
Although the runtime CI is green with nethost test project disabled, I wanted to get this fixed while working on it. It's a good thing that this issue is found. cc @jkoritzinsky, @akoeplinger also applied the tar->trusted change requested in other PR. |
akoeplinger
approved these changes
Jan 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is one test project in runtime repo
src/native/corehost/test/nativehostwhich I had to disable for LA64 https://github.com/dotnet/runtime/pull/111086/files#diff-5bcafd0b974a4d9e67ba425365ca903f8948b3268a57823761684170d2aa704bR5, because it was requiringGLIBCXX_3.4.31or above forstd::ios_base_library_init. Turned out we were not installing the latest available libstdc++-6 package because the parse method was overwriting the package unchecked.This PR moves the version comparison from install to parse, and overwrite the existing package based on higher version.