Arcade CI failing due to component governance errors#13331
Closed
epananth wants to merge 2 commits intodotnet:mainfrom
Closed
Arcade CI failing due to component governance errors#13331epananth wants to merge 2 commits intodotnet:mainfrom
epananth wants to merge 2 commits intodotnet:mainfrom
Conversation
5 tasks
Member
|
It looks like these came up after changes in #13210. @ViktorHofer FYI, in case you want to review this. |
ViktorHofer
requested changes
Apr 28, 2023
Member
ViktorHofer
left a comment
There was a problem hiding this comment.
Marking as request changes so that I can first take a look. Thanks for letting me know.
Member
Member
|
I submitted #13341 which is the better fix as it avoids these dependencies all-together. There's a remaining set of packages that are problematic, which I will work on in the next days:
We can enable Arcade's FlagNetStandard1xDependencies switch when those dependencies are updated and consumed. That will then guard against any future netstandard1.x dependencies being consumed. |
Member
Author
|
Thanks @ViktorHofer, going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
Issue -> #13326