[release/6.0] Add missing MicrosoftSourceLinkVersion property definition (#8145)#13204
Merged
mmitche merged 1 commit intodotnet:release/6.0from Apr 19, 2023
Merged
[release/6.0] Add missing MicrosoftSourceLinkVersion property definition (#8145)#13204mmitche merged 1 commit intodotnet:release/6.0from
mmitche merged 1 commit intodotnet:release/6.0from
Conversation
* Add missing MicrosoftSourceLinkVersion property definition * Update Versions.props
oleksandr-didyk
approved these changes
Apr 19, 2023
MichaelSimons
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interestingly, we have not updated the sourcelink used by repos in 6.0 since...2020. The reason was this missing property. While this change is a little risky, I think it's worth it from a compliance standpoint, since it will enable us to update sourcelink transitive dependencies and have them actually flow to repos.
To double check: