Introduce targets to filter target frameworks#12310
Merged
mmitche merged 4 commits intodotnet:mainfrom Feb 1, 2023
Merged
Conversation
Relies on dotnet/msbuild#8350 to be active or not cause build errors when not enabled. This is largely still experimental and may change. Enables the ability for an invocation of an arcade build to only build a desired set of target frameworks. The primary consumer is source-build. This allows source-build to simply remove TFMs from the build that would require SBRPs without extensive changes in project files.
d255b32 to
1c654fd
Compare
Member
|
@mmitche Can you advise on a setup to simulate and check this locally (e.g., repos to test with, etc.)? Cheers |
premun
reviewed
Jan 30, 2023
src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets
Show resolved
Hide resolved
src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets
Show resolved
Hide resolved
Member
|
To roll this out in source-build, is the idea we would enable this on a per repo basis starting at installer and then once all repos are onboarded we would enable it by default at the source-build level and remove the per repo settings? |
Member
Author
I only had a hacked up setup in source-build that was half working. This is now in the SDK, so I'm working on getting it into arcade for testing in non-SB setups. |
c74aad8 to
2bdc362
Compare
MichaelSimons
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on dotnet/msbuild#8350 to be active or not cause build errors when not enabled. This is largely still experimental and may change. Enables the ability for an invocation of an arcade build to only build a desired set of target frameworks. The primary consumer is source-build. This allows source-build to simply remove TFMs from the build that would require SBRPs without extensive changes in project files.
To double check: