Pass cancellation token to each of the file download/save operations#11870
Merged
mmitche merged 1 commit intodotnet:mainfrom Dec 7, 2022
Merged
Pass cancellation token to each of the file download/save operations#11870mmitche merged 1 commit intodotnet:mainfrom
mmitche merged 1 commit intodotnet:mainfrom
Conversation
Because the GetAsync call returns after the headers are read, the time based cancellation token isn't currently covering the file download (or save, for that matter). So it's possible that if there is an issue downloading the file content, we're not timing out and hitting the normal retry loop.
michellemcdaniel
approved these changes
Dec 7, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the GetAsync call returns after the headers are read, the time based cancellation token isn't currently covering the file download (or save, for that matter). So it's possible that if there is an issue downloading the file content, we're not timing out and hitting the normal retry loop.
To double check: