Skip to content

updated Microsoft.TemplateEngine.Authoring.Tasks version#11866

Merged
1 commit merged intodotnet:mainfrom
vlada-shubina:update-template-authoting-tasks
Dec 8, 2022
Merged

updated Microsoft.TemplateEngine.Authoring.Tasks version#11866
1 commit merged intodotnet:mainfrom
vlada-shubina:update-template-authoting-tasks

Conversation

@vlada-shubina
Copy link
Copy Markdown
Member

@vlada-shubina vlada-shubina commented Dec 7, 2022

Problem:

  1. Microsoft.TemplateEngine.Tasks 7.0.100-preview.2.22075.3 is not available in dotnet8 feed. Those repos which don't have dotnet7 feed enabled start to fail when using UsingToolTemplateLocalizer property. Example: https://dev.azure.com/dnceng-public/public/_build/results?buildId=104630&view=logs&j=fa59fe4e-195c-56fa-189b-58fd241f10dd
  2. Recently Microsoft.TemplateEngine.Tasks was renamed to `Microsoft.TemplateEngine.Authoring.Tasks

Solution

Updated dependency to use new package and its latest version. dotnet7 feed is no longer need when using UsingToolTemplateLocalizer property.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should dotnet/templating create darc subscriptions to arcade to keep these packages up to date?

(that wouldn't catch the package renames though)

@vlada-shubina
Copy link
Copy Markdown
Member Author

Should dotnet/templating create darc subscriptions to arcade to keep these packages up to date?

(that wouldn't catch the package renames though)

I hope that we won't rename this package again 😀

I can create the subscription if it doesn't create an additional burden for you. dotnet/templating is producing builds quite often, and Tasks package is always produced though changed very rarely (maybe we can use every week cadence to limit the flow).

@ghost
Copy link
Copy Markdown

ghost commented Dec 8, 2022

I can create the subscription if it doesn't create an additional burden for you. dotnet/templating is producing builds quite often, and Tasks package is always produced though changed very rarely (maybe we can use every week cadence to limit the flow).

It shouldn't be a problem. A weekly subscription sounds fine for this.

@vlada-shubina, should I merge this?

@vlada-shubina
Copy link
Copy Markdown
Member Author

I can create the subscription if it doesn't create an additional burden for you. dotnet/templating is producing builds quite often, and Tasks package is always produced though changed very rarely (maybe we can use every week cadence to limit the flow).

It shouldn't be a problem. A weekly subscription sounds fine for this.

@vlada-shubina, should I merge this?

yes, sure. I'll create subscription shortly.

@ghost ghost merged commit af32f24 into dotnet:main Dec 8, 2022
@vlada-shubina
Copy link
Copy Markdown
Member Author

Created:

https://github.com/dotnet/templating (.NET 8.0.1xx SDK) ==> 'https://github.com/dotnet/arcade' ('main')
  - Id: 2c726da8-885f-45d1-5fa6-08dad89f8b13
  - Update Frequency: EveryWeek
  - Enabled: True
  - Batchable: False
  - PR Failure Notification tags:
  - Merge Policies: []

Test PR: #11887

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant