Prepend native tool to the path for current build step#11030
Merged
jonfortescue merged 1 commit intodotnet:mainfrom Sep 29, 2022
Merged
Prepend native tool to the path for current build step#11030jonfortescue merged 1 commit intodotnet:mainfrom
jonfortescue merged 1 commit intodotnet:mainfrom
Conversation
Member
|
does this need to get ported to all the release branches? |
garath
approved these changes
Sep 27, 2022
Contributor
Author
|
Yes, unfortunately, and I'm already working on that. |
MattGal
approved these changes
Sep 27, 2022
Contributor
Author
|
It seems to be working in winforms, but I'm going to wait on merging/backporting until I confirm with Igor that it's working. |
Contributor
Author
|
Merging as this seems to have fixed the problem in winforms and the remaining failures are test failures. |
This was referenced Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in prepending the native tools to the path. Previously, they were prepended to the path but only for the next build step. This adds them to the current step as well.
Test for this here.