Skip to content

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Sep 14, 2022

When there are multiple source-build platforms, the manifest files will end up the same name (typically) unless set explicitly.

To double check:

When there are multiple source-build platforms, the manifest files will end up the same name (typically) unless set explicitly.
@mmitche
Copy link
Member Author

mmitche commented Sep 14, 2022

@crummel and @MichaelSimons We need to have different asset manifest file names, but I'm torn on this approach:

Pros:

  • Aligns with what repos do when they have multiple legs that may have overlap in nams

Cons:

  • Maybe should go somewhere in the props/targets files in arcade? But, I wasn't able to find a set of target properties that would be generally useable for generating the manifest file name...so maybe this is better?

@mmitche
Copy link
Member Author

mmitche commented Sep 19, 2022

@crummel @MichaelSimons If you get a chance this week, comments on this would be much appreciated. This should unblock the rid agnostic leg in runtime,

@mmitche mmitche merged commit 00e07eb into dotnet:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants