Fix HelixResultsDestinationDir default #10630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the expression appears as-is; no path is computed.
Contributor
Author
|
Who are the right reviewers / mergers? |
Contributor
Member
|
You've got the right folks on @BruceForstall - also, thanks for fixing. |
markwilkie
approved these changes
Aug 29, 2022
Contributor
|
Seems the missing ` was present since this file was added in #2103 and there were no issues all these years. |
Contributor
Author
My guess is nobody used the default. All the JIT pipelines set a value explicitly that is exactly this default but with the bug fixed. |
MattGal
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the expression appears as-is; no path is computed.
To double check: