Skip to content

Update Xunit to 2.4.2#10512

Merged
ViktorHofer merged 2 commits intodotnet:mainfrom
ericstj:updateXunit
Aug 22, 2022
Merged

Update Xunit to 2.4.2#10512
ViktorHofer merged 2 commits intodotnet:mainfrom
ericstj:updateXunit

Conversation

@ericstj
Copy link
Copy Markdown
Member

@ericstj ericstj commented Aug 19, 2022

No description provided.

@ericstj ericstj requested a review from ViktorHofer August 19, 2022 17:31
@ViktorHofer
Copy link
Copy Markdown
Member

/azp run arcade-ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Copy Markdown
Member

@dotnet/dnceng can you please help with diagnosing the test failures? I spent some time looking at the binlogs to see if the work items are submitted incorrectly but as the XUnitWorkItems feature is something very unfamiliar to me, I don't have any clues.

All work items fail with the following error:

✖DownloadError: Unable to download https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/1a5f89f6-d8da-4080-b15f-242650c914a8/nuget/v3/flat2/xunit.runner.console/2.4.2/xunit.runner.console.2.4.2.nupkg after retrying. Execution may fail as a result.

@dkurepa
Copy link
Copy Markdown
Member

dkurepa commented Aug 22, 2022

Looking at the logs, I think it's failing on trying to get xunit.runner.console 2.4.2 from the dotnet-eng, but it's not available, I'm only seeing 2.4.2-pre** packages. Should there be a xunit.runner.console 2.4.2 in there too?

@ViktorHofer
Copy link
Copy Markdown
Member

Yes, it was just recently published to nuget.org (two weeks ago). Can you please add the package to the dotnet-eng feed?

@dkurepa
Copy link
Copy Markdown
Member

dkurepa commented Aug 22, 2022

We usually add packages like this to the dotnet-public feed. I just checked and it's already there. Is it possible to fetch it from there?

@ViktorHofer
Copy link
Copy Markdown
Member

ViktorHofer commented Aug 22, 2022

If the 2.4.2 prerelease versions were pushed to dotnet-eng, then we should also push the stable version here. Otherwise people might not be able to resolve the 2.4.2 stable version that arcade propagates.

For the future we can for sure avoid having these in dotnet-eng.

@dkurepa
Copy link
Copy Markdown
Member

dkurepa commented Aug 22, 2022

I added 2.4.2 to dotnet-eng, should be unblocked now

@ViktorHofer
Copy link
Copy Markdown
Member

/azp run arcade-ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

ViktorHofer
ViktorHofer previously approved these changes Aug 22, 2022
@ViktorHofer ViktorHofer enabled auto-merge (squash) August 22, 2022 17:35
Copy link
Copy Markdown
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix the typo before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants