Skip to content

Updating default xcopy-msbuild to 17.2.1#10444

Merged
3 commits merged intomainfrom
missymessa-10422
Aug 16, 2022
Merged

Updating default xcopy-msbuild to 17.2.1#10444
3 commits merged intomainfrom
missymessa-10422

Conversation

@missymessa
Copy link
Copy Markdown
Member

To double check:

To fix: #10422

jkoritzinsky
jkoritzinsky previously approved these changes Aug 15, 2022
@ghost
Copy link
Copy Markdown

ghost commented Aug 15, 2022

This should also also be updated in tools.ps1 for consistency.

arcade/eng/common/tools.ps1

Lines 366 to 369 in 49b4958

# If the version of msbuild is going to be xcopied,
# use this version. Version matches a package here:
# https://dev.azure.com/dnceng/public/_packaging?_a=package&feed=dotnet-eng&package=RoslynTools.MSBuild&protocolType=NuGet&version=17.1.0&view=overview
$defaultXCopyMSBuildVersion = '17.1.0'

MattGal
MattGal previously approved these changes Aug 15, 2022
@missymessa missymessa dismissed stale reviews from MattGal and jkoritzinsky via 12b4ccd August 15, 2022 20:54
jkoritzinsky
jkoritzinsky previously approved these changes Aug 15, 2022
Co-authored-by: Ricardo Arenas <riarenas@microsoft.com>
@ghost
Copy link
Copy Markdown

ghost commented Aug 16, 2022

Merging this to unblock promotions. Thanks @missymessa!

@ghost ghost merged commit afc901d into main Aug 16, 2022
@akoeplinger akoeplinger deleted the missymessa-10422 branch November 22, 2022 10:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failed: dotnet-arcade-validation-official/main #20220812.3

3 participants