Skip to content

Add Queue Insights Documentation#10400

Merged
melotic merged 8 commits intomainfrom
melotic/add-qi-docs
Aug 12, 2022
Merged

Add Queue Insights Documentation#10400
melotic merged 8 commits intomainfrom
melotic/add-qi-docs

Conversation

@melotic
Copy link
Copy Markdown
Member

@melotic melotic commented Aug 11, 2022

To double check:

This PR adds documentation on Queue Insights.

@AlitzelMendez AlitzelMendez requested review from a user and garath August 11, 2022 22:57
@ghost
Copy link
Copy Markdown

ghost commented Aug 12, 2022

@ilyas1974 In case you have any feedback on whether this is a good location for the document.

ghost
ghost previously approved these changes Aug 12, 2022
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We probably want eyes that weren't involved in the project to take a look to make sure it's good for the audience.

Co-authored-by: Michael Stuckey <michael.stuckey@gmail.com>
Justin Perez and others added 2 commits August 12, 2022 13:20
Co-authored-by: Michael Stuckey <michael.stuckey@gmail.com>
Co-authored-by: Michael Stuckey <michael.stuckey@gmail.com>
@garath
Copy link
Copy Markdown
Member

garath commented Aug 12, 2022

Consider adding a note at the top or at the bottom about how to generally get help. Something like

Please contact the .NET Engineering Services Team with any questions about this service.

@ghost
Copy link
Copy Markdown

ghost commented Aug 12, 2022

Please contact the .NET Engineering Services Team with any questions about this service.

If anything, Let's move the feedback section to the top then. I really want them to use the submit feedback to ask about this instead of random questions through other communication channels.

@garath
Copy link
Copy Markdown
Member

garath commented Aug 12, 2022

Looks great to me! None of my comments are deal-breakers. Good work.

@melotic
Copy link
Copy Markdown
Member Author

melotic commented Aug 12, 2022

Thanks for the feedback :)

@melotic melotic enabled auto-merge (squash) August 12, 2022 20:33
@melotic melotic merged commit f84d1d8 into main Aug 12, 2022
@akoeplinger akoeplinger deleted the melotic/add-qi-docs branch November 22, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants