Use min VS version in tools.ps1 InitializeVisualStudioMSBuild if global.json doesn't provide it#10160
Merged
akoeplinger merged 2 commits intodotnet:mainfrom Aug 10, 2022
Merged
Conversation
…al.json doesn't provide it Otherwise running `eng\common\build.ps1 -msbuildEngine vs` results in an error if the global.json doesn't have a `vs` key: ``` The property 'vs' cannot be found on this object. Verify that the property exists. ``` This is similar to what we do in https://github.com/dotnet/arcade/blob/b2dad1fa64b4b80f7f4480782cf4ebf2f5fbbcda/eng/common/sdk-task.ps1#L63-L65
premun
previously approved these changes
Aug 9, 2022
premun
reviewed
Aug 9, 2022
premun
approved these changes
Aug 9, 2022
MattGal
approved these changes
Aug 9, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise running
eng\common\build.ps1 -msbuildEngine vsresults in an error if the global.json doesn't have avskey (like we do in dotnet/runtime):This is similar to what we do in
arcade/eng/common/sdk-task.ps1
Lines 63 to 65 in b2dad1f