Force .NET rollforward for SBOM ManifestTool#10137
Merged
epananth merged 1 commit intorelease/6.0from Jul 29, 2022
Merged
Conversation
The ManifestTool targets .NET Core 3.1, which is not available in most Arcade repos. Adding it to global.json as a required "test" runtime breaks restore + build on ARM64 systems, which isn't ideal. Instead, force rollforward to the latest major runtime even though the application's manifest doesn't specify that. Works around microsoft/dropvalidator#454.
548bd0e to
b9f4ee6
Compare
Member
|
Cool @rainersigwald - and it worked? |
Member
Author
|
I didn't validate, just trying to get @epananth a jump on this if y'all decide to go this route rather than waiting for the tool to be updated. |
Member
|
I was oof, I will run the test and get back to this. |
Member
|
that worked this is the test build https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6484672&view=results this should work. Thanks @rainersigwald. |
epananth
approved these changes
Jul 28, 2022
Member
|
since this is going into release/6.0 it needs approval from @markwilkie and @mmitche |
mmitche
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ManifestTool targets .NET Core 3.1, which is not available in most Arcade repos. Adding it to global.json as a required "test" runtime breaks restore + build on ARM64 systems, which isn't ideal.
Instead, force rollforward to the latest major runtime even though the application's manifest doesn't specify that.
Works around microsoft/dropvalidator#454.
To double check: