-
Notifications
You must be signed in to change notification settings - Fork 377
Create BestPractices.md #10074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create BestPractices.md #10074
Conversation
Co-authored-by: Missy Messa <47990216+missymessa@users.noreply.github.com>
Updated based on feedback
Added information about closing issues.
Changes made based on feedback
| @@ -0,0 +1,19 @@ | |||
| # Best Practices for .NET Engineering Services | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @ilyas1974, thanks for writing it up. What do you think the best way to track how we're doing is? Should we start looking at metrics for our own CI build breaks? Other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question - let me think on that. Perhaps a note in a teams channel (maybe roll out or FR Internal) letting the team know that someone is working on a repo that is not "green"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting back around to this - we've been doing a good job of monitoring things through FR and I think we will continue to do so. We'll report on it during the weekly stand up. Hopefully we won't have to do this often as the team will start following up on the issues they are involved in.
markwilkie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - let's try this out and adjust as required.
To double check:
Feel free to make suggestions on best practices that you think should be added to this document.