Skip to content

Conversation

@ilyas1974
Copy link

To double check:

Feel free to make suggestions on best practices that you think should be added to this document.

@ilyas1974 ilyas1974 requested review from MattGal and markwilkie July 19, 2022 17:23
Ilya Skuratovsky and others added 2 commits July 19, 2022 10:49
Co-authored-by: Missy Messa <47990216+missymessa@users.noreply.github.com>
MattGal
MattGal previously approved these changes Jul 19, 2022
Ilya Skuratovsky added 2 commits July 19, 2022 13:33
MattGal
MattGal previously approved these changes Jul 19, 2022
Added information about closing issues.
Changes made based on feedback
@@ -0,0 +1,19 @@
# Best Practices for .NET Engineering Services
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @ilyas1974, thanks for writing it up. What do you think the best way to track how we're doing is? Should we start looking at metrics for our own CI build breaks? Other?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question - let me think on that. Perhaps a note in a teams channel (maybe roll out or FR Internal) letting the team know that someone is working on a repo that is not "green"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting back around to this - we've been doing a good job of monitoring things through FR and I think we will continue to do so. We'll report on it during the weekly stand up. Hopefully we won't have to do this often as the team will start following up on the issues they are involved in.

Copy link
Member

@markwilkie markwilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - let's try this out and adjust as required.

@ilyas1974 ilyas1974 merged commit c71b1a8 into main Aug 30, 2022
@akoeplinger akoeplinger deleted the ilyas-devguide branch November 22, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants