Add support for required keyword #10021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also avoid emitting the new `CompilerFeatureRequiredAttribute`
Use the one that the project is compiling with. This is a copy of the logic from https://github.com/dotnet/sdk/blob/d670c1d9c72190cdf8228ed000847f9bde55ce71/src/Compatibility/Microsoft.DotNet.Compatibility/ValidatePackage.cs#L47
ViktorHofer
previously approved these changes
Jul 14, 2022
Member
ViktorHofer
left a comment
There was a problem hiding this comment.
This looks great to me. Approving, assuming that you tested this for dotnet/runtime locally.
Member
Author
|
I did test locally but will push up a draft PR to test in dotnet/runtime across the larger CI matrix to make sure nothing funny is going on. |
333fred
reviewed
Jul 14, 2022
src/Microsoft.Cci.Extensions/Writers/CSharp/CSDeclarationWriter.Attributes.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Cci.Extensions/Writers/CSharp/CSDeclarationWriter.Attributes.cs
Show resolved
Hide resolved
333fred
reviewed
Jul 14, 2022
src/Microsoft.Cci.Extensions/Writers/CSharp/CSDeclarationWriter.Attributes.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Here's the test PR: dotnet/runtime#72233 |
333fred
approved these changes
Jul 15, 2022
Member
333fred
left a comment
There was a problem hiding this comment.
Generation changes LGTM. I did not review the other changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit-by-commit.
This adds support for the
requiredkeyword into GenApi and then also makesGenFacadeshonorLangVersionand use the compiler version that the project is already using (similar to what we do for new API Compat).This should fix dotnet/runtime#71559