Skip to content

Failing tests don't fail build when warningsAsErrors is false #1589

@ryanbrandenburg

Description

@ryanbrandenburg

We've started setting warningsAsErrors to false in our builds of Arcade projects because that's what we did before, and we have some warnings that would currently cause us to start failing, but when we do this test failures don't fail the build because they're only logged as warnings. I suspect this is caused by this line, where LogStandardErrorAsError="false". I've noticed that that's set that way in a couple different Exec's, so possibly this is not the only area affected.

Repro:

  1. Clone git@github.com:aspnet/Extensions.git
  2. git checkout rybrande/Arcade
  3. .\build.cmd

That takes a while to run, but if I'm right it should replicated against any arcade repo with a failing test against which warnaserrors=false was passed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions