-
Notifications
You must be signed in to change notification settings - Fork 383
Description
Context
Base issue: #11225
Reference package path: microsoft.extensions.logging
Roslyn-based GenAPI location: https://github.com/dotnet/sdk/tree/main/src/GenAPI/
Usage:
/repos/source-build-reference-packages]# ./generate.sh --pkg microsoft.extensions.logging,2.1.1 --genapi-backend roslyn --dest /repos/source-build-reference-packages/src/referencePackages/roslyn/
Steps:
- Generate SBRP package using SBRP generator with the roslyn-based backend
- Compare cci-based <-> roslyn-based reference assemblies
- Build the SBRP generated with the roslyn-based backend
- Collect issues, their occurrence, create bugs for each.
- Run the
sdk/ApiCompattool to compare generated API with original
How to compile project in SBRP
Use a docker or a VM and from root folder of source-build-reference-packages run:
/repos/source-build-reference-packages]# ./build.sh --projects ./build.sh --projects /repos/source-build-reference-packages/src/referencePackages/roslyn/system.memory/4.5.1/System.Memory.4.5.1.csproj
How to use the ApiCompat tool
sdk\artifacts\bin\Microsoft.DotNet.ApiCompat.Tool\Debug\net6.0> .\Microsoft.DotNet.ApiCompat.Tool.exe --strict-mode true --enable-rule-attributes-must-match true --enable-rule-cannot-change-parameter-name true --lref ... --rref ... -l ... -r ...
Found Issues:
Microsoft.Extensions.Logging: Occurrence: 23
Microsoft.Extensions.Options: 13
public static partial class LoggingServiceCollectionExtensions
{
+ public static DependencyInjection.IServiceCollection AddLogging(this DependencyInjection.IServiceCollection services) { throw null; }
- public static DependencyInjection.IServiceCollection AddLogging(DependencyInjection.IServiceCollection services) { throw null; }
}- error CS3024: Constraint type 'ILoggerProvider' is not CLS-compliant
Occurrence: 8