Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c453dfe
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 02980a6
Choose a head ref
  • 4 commits
  • 12 files changed
  • 2 contributors

Commits on Feb 6, 2023

  1. [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade dotn… 

    …et/sourcelink (#12404)

[main] Update dependencies from dotnet/xliff-tasks dotnet/arcade dotnet/sourcelink
    @dotnet-maestro
    dotnet-maestro[bot] authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    77f2a22 View commit details
    Browse the repository at this point in the history

  2. Update dependencies from https://github.com/dotnet/xharness build 202… 

    …30202.1 (#12443)

[main] Update dependencies from dotnet/xharness
    @dotnet-maestro
    dotnet-maestro[bot] authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    db243ca View commit details
    Browse the repository at this point in the history

  3. Update dependencies from https://github.com/dotnet/sourcelink build 2… 

    …0230205.1 (#12446)

[main] Update dependencies from dotnet/sourcelink
    @dotnet-maestro
    dotnet-maestro[bot] authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    ef45202 View commit details
    Browse the repository at this point in the history

  4. Fix project build exclusion logic in the face of static graph (#12425) 

    * Fix project build exclusion logic in the face of static graph
While working on filtering, I discovered that static graph and target filtering do not play nicely together. After some help from the msbuild team, the problem was identified. Arcade typically uses a series of empty targets that override standard targets (or its own) to avoid executing a project build or restore. Static graph, however, uses the existence of the _IsProjectRestoreSupported target, rather than its return value to determine whether restore is supported. This means that any excluded project still gets restored in static graph mode.

The fix (or workaround, depending on how you look at it) for this is to set the NuGetRestoreTargets file to an empty stub early enough in the build (in the BeforeCommonTargets hook) so that this target is never loaded at all. This requires determining whether a build will be skipped earlier than we do today, in BeforeCommonTargets rather than in Sdk.targets.

The code has been refactored so that we determine whether a build should be skipped in ExcludeFromBuild.BeforeCommonTargets.targets, which is imported in the BeforeCommonTargets files. I've also moved the import of these files earlier so that in cases where the BeforeCommonTargets SDK hook is **not** used (see #2676), we will still compute the exclusion properties early enough to import "Empty.targets". In that case, we also create the target.
    @mmitche
    mmitche authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    02980a6 View commit details
    Browse the repository at this point in the history
Loading