Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ab42d24
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9467b10
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 11, 2021

  1. Send additional properties in job created by SendHelixJob (#7083) 

    ## Description

This change is part of moving servicing jobs to COGS subscription: https://github.com/dotnet/core-eng/issues/11639.

We need to include `System.PullRequest.TargetBranch` pipeline variable in Helix job properties to be able to redirect PR test jobs to servicing subscription. Currently Helix API has no way to tell if the PR was created for `main` or `release/*` branch.

I also added other properties that are send in `main` for consistency and backported `SendHelixJob.AddBuildVariableProperty()` method from the latest code because it was not yet implemented here.

Related issue: #7074

## Customer Impact

There is no customer impact. Only effect is that additional properties will be attached to Helix job.

## Regression

No

## Risk

The risk of this change is very low. Change is very small and the same code already runs on main.

## Workarounds

There is no workaround available. Without this change we won't be able to redirect servicing PR test jobs to COGS subscription.
    Łukasz Patalas authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    9467b10 View commit details
    Browse the repository at this point in the history
Loading