Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9ffc76a
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e1ea887
Choose a head ref
  • 10 commits
  • 22 files changed
  • 6 contributors

Commits on Jan 19, 2022

  1. [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade (#8358)

    [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade
    dotnet-maestro[bot] authored Jan 19, 2022
    Configuration menu
    Copy the full SHA
    3d60d37 View commit details
    Browse the repository at this point in the history
  2. Updating wording (#8360)

    missymessa authored Jan 19, 2022
    Configuration menu
    Copy the full SHA
    10d25e7 View commit details
    Browse the repository at this point in the history
  3. Avoid duplicate BestTargetFrameworks in TargetFramework.Sdk (#8361)

    * Avoid duplicate BestTargetFrameworks in TargetFramework.Sdk
    
    Avoid duplicates being returned by the ChooseBestTargetFrameworks task which leads to unnecessary inner project builds.
    
    * Update ChooseBestTargetFrameworksTask.cs
    
    * Update ChooseBestTargetFrameworksTask.cs
    ViktorHofer authored Jan 19, 2022
    Configuration menu
    Copy the full SHA
    8c1b3eb View commit details
    Browse the repository at this point in the history
  4. Use 1ES pools in templates that run internally (#8344)

    * Use 1ES pools in templates that run internally
    - Use the 1ES pools in our templates, jobs, etc.
    - To reduce some of the cost of this, remove the "Setup Maestro Vars" job and replace with a step so that we don't end up with an additional allocation in those cases.
    - Call setup maestro vars to populate the azdo params in execute-sdl
    mmitche authored Jan 19, 2022
    Configuration menu
    Copy the full SHA
    bb21472 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Configuration menu
    Copy the full SHA
    cbbbaba View commit details
    Browse the repository at this point in the history
  2. Fix build break because of missing metdata (#8364)

    * Fix build break because of missing metdata
    
    In the previous change I didn't notice that the binplacing logic depends on metadata passing in being preserved in the items being returned. Because of that, I revert the collection change from List to HashSet and instead manually iterate through the list. The binplacing logic depends on duplicates being allowed versus the inner build project logic explicitly doesn't want duplicates to avoid unnecessary inner builds, hence adding a switch for it.
    
    * Update Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.targets
    
    * Update ChooseBestTargetFrameworksTask.cs
    ViktorHofer authored Jan 20, 2022
    Configuration menu
    Copy the full SHA
    1c78e43 View commit details
    Browse the repository at this point in the history
  3. [main] Update dependencies from dotnet/xliff-tasks dotnet/linker (#8367)

    [main] Update dependencies from dotnet/xliff-tasks dotnet/linker
    dotnet-maestro[bot] authored Jan 20, 2022
    Configuration menu
    Copy the full SHA
    6fee09d View commit details
    Browse the repository at this point in the history
  4. Delete unnecessary task in TFM.Sdk (#8366)

    * Delete unnecessary task in TFM.Sdk
    
    * Update Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.csproj
    
    * Update Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.targets
    
    * Remove netcoreapp pattern
    
    dotnet/runtime doesn't build against netcoreappX.X-* tfms anymore, hence the pattern can be deleted.
    
    * Update Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.props
    ViktorHofer authored Jan 20, 2022
    Configuration menu
    Copy the full SHA
    085dfd6 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Add NuGet.config for eng/common/internal/tools.csproj (#8309)

    Add NuGet.config for eng/common/internal/tools.csproj
    riarenas authored Jan 21, 2022
    Configuration menu
    Copy the full SHA
    39b1072 View commit details
    Browse the repository at this point in the history
  2. Fix DevDiv promotion job (#8370)

    - Ensure devdiv promotion job uses devdiv pools
    - Use powershell core (the pools don't have IE initialized so we have to use basic parsing, which is default on powershell core)
    mmitche authored Jan 21, 2022
    Configuration menu
    Copy the full SHA
    e1ea887 View commit details
    Browse the repository at this point in the history
Loading