Allow MaximumCompatibleNDKMajorVersion=28#263
Merged
jonathanpeppers merged 1 commit intomainfrom Oct 15, 2025
Merged
Conversation
Context: dotnet/android@80559b5 We are already using the 28.x Android NDK, so we should allow it here. I also updated a unit test that was outdated.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the maximum compatible Android NDK major version from 26 to 28, aligning the code with the actual NDK version already in use. The change ensures that the system can properly recognize and work with NDK 28.x versions.
Key changes:
- Updated
MaximumCompatibleNDKMajorVersionconstant from 26 to 28 in production code - Enhanced unit test to include NDK versions 26-28 and verify correct version selection logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Xamarin.Android.Tools.AndroidSdk/Sdks/AndroidSdkBase.cs | Updated the maximum compatible NDK version constant from 26 to 28 |
| tests/Xamarin.Android.Tools.AndroidSdk-Tests/AndroidSdkInfoTests.cs | Updated test constant and added NDK versions 26-28 to test array; changed expected version logic to use second-to-last element |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android@80559b5
We are already using the 28.x Android NDK, so we should allow it here.
I also updated a unit test that was outdated.