Return empty properties when Java fails to run#255
Merged
jonathanpeppers merged 1 commit intodotnet:mainfrom Jun 27, 2025
Merged
Return empty properties when Java fails to run#255jonathanpeppers merged 1 commit intodotnet:mainfrom
jonathanpeppers merged 1 commit intodotnet:mainfrom
Conversation
If the Java executable we are trying to run fails to be be executed (i.e., locked file, broken symlink, or any raeson actually) we should just return an empty dictionary. That way when running `GetPathEnvironmentJdkPaths`, the invalid/not available executable is just ignored. Call stack from https://developercommunity.visualstudio.com/t/visual-studio-does-not-see-detect-the-co/10888076 ``` System.ComponentModel.Win32Exception (0x80004005): The system cannot find the path specified at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo) at Xamarin.Android.Tools.ProcessUtils.Exec(ProcessStartInfo processStartInfo, DataReceivedEventHandler output, Boolean includeStderr) at Xamarin.Android.Tools.JdkInfo.GetJavaProperties(Action`2 logger, String java) at Xamarin.Android.Tools.JdkInfo.<GetPathEnvironmentJdkPaths>d__61.MoveNext() ``` The message `The system cannot find the path specified` is a bit misleading because we are already validating the file exist before calling `GetJavaProperties`, and this can only occurr if we found a broken symlink.
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
jonathanpeppers
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the Java executable we are trying to run fails to be be executed (i.e., locked file, broken symlink, or any raeson actually) we should just return an empty dictionary. That way when running
GetPathEnvironmentJdkPaths, the invalid/not available executable is just ignored.Call stack from https://developercommunity.visualstudio.com/t/visual-studio-does-not-see-detect-the-co/10888076
The message
The system cannot find the path specifiedis a bit misleading because we are already validating the file exist before callingGetJavaProperties, and this can only occurr if we found a broken symlink.