Bump to mono/mono/2019-06@5608fe0a #3701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: mono/mono@7af64d1...5608fe0 Context: mono/mono#16395 Context: mono/mono#16486 Context: mono/mono#16712 Context: mono/mono#17064 Context: dotnet/macios#7005
Context: http://build.azdo.io/3085600 Context: Homebrew/homebrew-core#44608 On 2019-Sep-26, or thereabouts, we started seeing this build error: ==> Downloading https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz stderr | curl: (22) The requested URL returned error: 404 Not Found stderr | Error: An exception occurred within a child process: stderr | DownloadError: Failed to download resource "ant--bcel" stderr | Download failed: https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz Error: Installation of ant failed This is coming from `brew install ant`. Apparently, something related to the [Homebrew `ant` Formulae][0] has broken recently, and all attempts to use Homebrew to install `ant` are failing, worldwide. Looking into it, we only use `ant` and a related `<Ant/>` task to build `src/proguard`, and ProGuard has instructions to instead build with `maven`, `gradle`, and `javac` (among others). Meaning we don't actually *need* `ant` *at all*. I reworked `src/proguard` to be built with `gradle`, the same way we are building `r8.jar`. This allows us to not need `ant` anymore, and thus avoid the `brew install ant` error. [0]: https://formulae.brew.sh/formula/ant
Restores the instrumentation timeout for the NUnit set of BCL tests to 60 minutes, which was the previous timeout value prior to commit 3d9b154.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: mono/mono@7af64d1...5608fe0
Context: mono/mono#16395
Context: mono/mono#16486
Context: mono/mono#16712
Context: mono/mono#17064
Context: dotnet/macios#7005