Skip to content

Revert "[Xamarin.Android.Build.Tasks] Fix Facade assembly deployment" #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonpryor merged 1 commit into from
Jan 10, 2017
Merged

Revert "[Xamarin.Android.Build.Tasks] Fix Facade assembly deployment" #357

jonpryor merged 1 commit into from
Jan 10, 2017

Conversation

@jonpryor
Copy link
Contributor

@jonpryor jonpryor commented Jan 10, 2017

Reverts #337

Commit a7beb70 broke unit test execution. Jenkins build #190
ran 128 tests, while Jenkins build #191 executed 6.
Build #191 only contains two commits, and commit bf1bc93 --
PR #354 -- doesn't look like a plausible source of error.

The cause of the "broken unit test execution" is that the on-device
unit tests are exiting with an error:

Task "RunInstrumentationTests"
        ....
        INSTRUMENTATION_RESULT: shortMsg=android.runtime.JavaProxyThrowable
        INSTRUMENTATION_RESULT: longMsg=android.runtime.JavaProxyThrowable: System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime.Serialization, Version=2.0.5.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' or one of its dependencies.
...
xamarin-android/build-tools/scripts/UnitTestApks.targets:  warning : No `nunit2-results-path` bundle value found in command output! Cannot find NUnit2 XML output!

Commit a7beb70 stopped deploying facade assemblies, including
System.Runtime.Serialization, which is why it can't be found.

Revert commit a7beb70 so that on-device unit tests execute.

@jonpryor jonpryor merged commit 6f864b9 into master Jan 10, 2017
@jonpryor jonpryor deleted the revert-337-fixassemblies branch July 27, 2018 21:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonpryor @dnfclas