Bump java-interop for fixed cecil build#3167
Merged
jonpryor merged 6 commits intodotnet:masterfrom Jun 7, 2019
Merged
Conversation
Changes:
[Java.Interop] JniMethodInfo.ToString() shouldn't throw (dotnet#425)
[java-interop] Migrate to C++ (dotnet#427)
Fix build with newer cecil (from overriden source path) (dotnet#428)
As they changed after we migrated Java.Interop to C++
grendello
approved these changes
Jun 5, 2019
Java.Interop migrated most of the C source to C++.
That fixes this error:
(ValidateSolutionConfiguration target) ->
/Users/rodo/git/xa3/external/mono/external/cecil/Mono.Cecil.sln.metaproj : error MSB4126: The specified solution configuration "Debug|Any CPU" is invalid. Please specify a valid solution configuration using the Configuration and Platform properties (e.g. MSBuild.exe Solution.sln /p:Configuration=Debug /p:Platform="Any CPU") or leave those properties blank to use the default solution configuration. [/Users/rodo/git/xa3/external/mono/external/cecil/Mono.Cecil.sln]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: