Migrate WarnOnPreserveAttribute from ILLink step to MSBuild task#10693
Merged
jonathanpeppers merged 3 commits intomainfrom Jan 15, 2026
Merged
Migrate WarnOnPreserveAttribute from ILLink step to MSBuild task#10693jonathanpeppers merged 3 commits intomainfrom
jonathanpeppers merged 3 commits intomainfrom
Conversation
Replace the ILLink custom step with an MSBuild task that runs before _RunILLink. This simplifies the build pipeline by removing a dependency on the ILLink step infrastructure while maintaining the same behavior. The new CheckForObsoletePreserveAttribute task uses System.Reflection.Metadata for fast metadata scanning instead of Mono.Cecil.
Address PR feedback: move _CheckForObsoletePreserveAttribute target from ILLink.targets to AssemblyResolution.targets so it runs on all builds, not just Release/trimmed builds. This gives developers earlier feedback about using the obsolete attribute.
grendello
reviewed
Jan 15, 2026
src/Xamarin.Android.Build.Tasks/Tasks/CheckForObsoletePreserveAttribute.cs
Show resolved
Hide resolved
jonathanpeppers
approved these changes
Jan 15, 2026
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
There are some flaky test failures we can ignore, merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the ILLink custom step with an MSBuild task that runs before _RunILLink. This simplifies the build pipeline by removing a dependency on the ILLink step infrastructure while maintaining the same behavior.
The new CheckForObsoletePreserveAttribute task uses System.Reflection.Metadata for fast metadata scanning instead of Mono.Cecil.