Enable more tests to run on all 3 runtimes, part 8#10616
Merged
jonathanpeppers merged 24 commits intomainfrom Dec 3, 2025
Merged
Enable more tests to run on all 3 runtimes, part 8#10616jonathanpeppers merged 24 commits intomainfrom
jonathanpeppers merged 24 commits intomainfrom
Conversation
df5fb54 to
6b5ca89
Compare
jonathanpeppers
approved these changes
Dec 2, 2025
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
This looks good, I reran the failing lanes.
6b5ca89 to
2901a2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the test data generation for
ManifestTestby replacing the static array of test cases with a dynamic data provider method. This makes it easier to extend and maintain the test cases, especially as newAndroidRuntimevalues are added.Test data generation improvements:
DebuggerAttributeCasesarray with theGet_DebuggerAttributeCases_Datamethod, which dynamically generates test cases for all values of theAndroidRuntimeenum.AddTestDatawithinGet_DebuggerAttributeCases_Datato streamline the creation of each test case entry.