[workload-dependencies] fix blank $(DotNetStableTargetFramework)#10479
Merged
jonathanpeppers merged 1 commit intomainfrom Sep 12, 2025
Merged
[workload-dependencies] fix blank $(DotNetStableTargetFramework)#10479jonathanpeppers merged 1 commit intomainfrom
$(DotNetStableTargetFramework)#10479jonathanpeppers merged 1 commit intomainfrom
Conversation
Local builds can fail with:
> ./dotnet-local.cmd build build-tools/create-packs/Microsoft.Android.Sdk.proj -t:ConfigureLocalWorkload
Restore complete (2.2s)
WorkloadDependencies failed with 2 error(s) (1.0s)
D:\src\android\bin\Debug\dotnet\sdk\9.0.305\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(96,5): error NETSDK1013: The TargetFramework value '' was not recognized. It may be misspelled. If not, then the TargetFrameworkIdentifier and/or TargetFrameworkVersion properties must be specified explicitly. [D:\src\android\tools\workload-dependencies\workload-dependencies.csproj]
D:\src\android\tools\workload-dependencies\WorkloadDependencies.proj(83,5): error MSB3073: The command "dotnet run --project "D:\src\android\tools\workload-dependencies\workload-dependencies.csproj" -p:MonoOptionsVersion=6.12.0.148 -p:NewtonsoftJsonPackageVersion=13.0.3 -- "--feed=https://aka.ms/AndroidManifestFeed/d17-12" -o "D:\src\android\bin\BuildDebug\nuget-unsigned\workload-manifest\WorkloadDependencies.json" --build-tools-version=35.0.0 --cmdline-tools-version=12.0 --jdk-version=17.0.14 --jdk-max-version=21.0.99 --ndk-version=26.3.11579264 --platform-tools-version=34.0.5 --platform-version=android-35 --preview-platform-version=36 --workload-version=35.0.2" exited with code 1.
Build failed with 2 error(s) in 9.5s
Because `tools\workload-dependencies\Directory.Build.props` exists, we
don't get the value from the root `Directory.Build.props`.
I think we should simply set `$(DotNetStableTargetFramework)` if
blank, and we'll have one more place to update when moving to .NET 11,
etc.
grendello
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local builds can fail with:
Because
tools\workload-dependencies\Directory.Build.propsexists, we don't get the value from the rootDirectory.Build.props.I think we should simply set
$(DotNetStableTargetFramework)if blank, and we'll have one more place to update when moving to .NET 11, etc.