[Mono.Android] introduce $(_AndroidIsAssignableFromCheck) escape hatch#10475
Merged
[Mono.Android] introduce $(_AndroidIsAssignableFromCheck) escape hatch#10475
$(_AndroidIsAssignableFromCheck) escape hatch#10475Conversation
Forward port of: #10473 Context: https://github.com/jonathanpeppers/IntuneReproNet9 Context: 35f41dc Context: 9a27140 .NET 9 introduced a Java "instanceof" check for multiple reasons: if (!JniEnvironment.Types.IsAssignableFrom (handleClass, typeClass)) { return null; } The problem with this check, is that it fails in combination with the package: <PackageReference Include="Microsoft.Intune.Maui.Essentials.android" Version="11.0.0-develop" /> `LayoutInflater.From (Context)` returns `null` due to: Handle 0x7f346ad02d is of type 'com/android/internal/policy/PhoneLayoutInflater' which is not assignable to 'com/microsoft/intune/mam/client/view/MAMLayoutInflater' To solve this: * Introduce `-p:_AndroidIsAssignableFromCheck=false` to disable the check, defaulting to `true` for .NET 9+. * Add a test that calls `LayoutInflater.From (Context)` and verify it returns non-null. * Add a test entry in `IsAssignableFromRemaps.xml` to remap `com.microsoft.intune.mam.client.view.MAMLayoutInflater` to a test Java class `net.dot.android.test.MyLayoutInflater` that extends `android.view.LayoutInflater`. I introduced a new test run configuration "IsAssignableFrom" to leverage the new property `-p:_AndroidIsAssignableFromCheck=false`, and only run the `Intune` category.
Member
Author
|
The test looks good: 
The full logs are not available to review because all APK tests passed. I will test locally. |
Member
Author
|
The logs locally, look OK: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of: #10473
Context: https://github.com/jonathanpeppers/IntuneReproNet9
Context: 35f41dc
Context: 9a27140
.NET 9 introduced a Java "instanceof" check for multiple reasons:
The problem with this check, is that it fails in combination with the package:
LayoutInflater.From (Context)returnsnulldue to:To solve this:
Introduce
-p:_AndroidIsAssignableFromCheck=falseto disable the check, defaulting totruefor .NET 9+.Add a test that calls
LayoutInflater.From (Context)and verify it returns non-null.Add a test entry in
IsAssignableFromRemaps.xmlto remapcom.microsoft.intune.mam.client.view.MAMLayoutInflaterto a test Java classnet.dot.android.test.MyLayoutInflaterthat extendsandroid.view.LayoutInflater.I introduced a new test run configuration "IsAssignableFrom" to leverage the new property
-p:_AndroidIsAssignableFromCheck=false, and only run theIntunecategory.