[WIP] Fix NRT annotations in src\Xamarin.Android.Build.Tasks\#10393
Merged
jonathanpeppers merged 4 commits intomainfrom Aug 8, 2025
Merged
[WIP] Fix NRT annotations in src\Xamarin.Android.Build.Tasks\#10393jonathanpeppers merged 4 commits intomainfrom
src\Xamarin.Android.Build.Tasks\#10393jonathanpeppers merged 4 commits intomainfrom
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix NRT annotations in
src\Xamarin.Android.Build.Tasks\Utilitiesfollowing repository guidelinesThis PR systematically updates nullable reference type annotations in the Utilities directory to follow the established patterns outlined in
copilot-instructions.md.Plan
Phase 1: Convert #nullable disable to #nullable enable (5 files at a time)
Phase 2: Update MSBuild Task property patterns
Phase 3: Update helper and utility classes
Pattern Changes Applied:
#nullable disableto#nullable enablestring Property { get; set; } = ""List<ITaskItem> Items { get; set; } = []string? field,AssemblyDescriptor? descriptor,StructureInfo? infoparam ?? defaultValueInstance?.Property ?? defaultValueContext #10326.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.