Don't use blocking acknowledgments when there is no need to#1940
Merged
adamsitnik merged 5 commits intomasterfrom Mar 11, 2022
Merged
Don't use blocking acknowledgments when there is no need to#1940adamsitnik merged 5 commits intomasterfrom
adamsitnik merged 5 commits intomasterfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BDN uses std input and output to synchronize the host and benchmark process (it's simple and it usually works everywhere):
BenchmarkDotNet/src/BenchmarkDotNet/Templates/BenchmarkProgram.txt
Line 35 in fa59841
BenchmarkDotNet/src/BenchmarkDotNet/Loggers/SynchronousProcessOutputLoggerWithDiagnoser.cs
Lines 55 to 57 in fa59841
BenchmarkDotNet/src/BenchmarkDotNet/Loggers/SynchronousProcessOutputLoggerWithDiagnoser.cs
Line 61 in fa59841
BenchmarkDotNet/src/BenchmarkDotNet/Engines/ConsoleHost.cs
Lines 32 to 34 in fa59841
Example: benchmark process prints "// AfterAll", host process starts the disassembler, attaches to the benchmark process, gets the disassembly and writes the ack.
This causes 3 kinds of issues:
With this PR the blocking acknowledgments will be enabled only for users who use a diagnoser that actually needs it. And users will be able to run the produced exe without providing any input: