Skip to content

Don't use blocking acknowledgments when there is no need to#1940

Merged
adamsitnik merged 5 commits intomasterfrom
noSignals
Mar 11, 2022
Merged

Don't use blocking acknowledgments when there is no need to#1940
adamsitnik merged 5 commits intomasterfrom
noSignals

Conversation

@adamsitnik
Copy link
Member

BDN uses std input and output to synchronize the host and benchmark process (it's simple and it usually works everywhere):

Example: benchmark process prints "// AfterAll", host process starts the disassembler, attaches to the benchmark process, gets the disassembly and writes the ack.

This causes 3 kinds of issues:

With this PR the blocking acknowledgments will be enabled only for users who use a diagnoser that actually needs it. And users will be able to run the produced exe without providing any input:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants