net5.0 does not contain "core" word but it's a .NET Core moniker#1479
Merged
AndreyAkinshin merged 5 commits intomasterfrom Jul 16, 2020
Merged
net5.0 does not contain "core" word but it's a .NET Core moniker#1479AndreyAkinshin merged 5 commits intomasterfrom
AndreyAkinshin merged 5 commits intomasterfrom
Conversation
AndreyAkinshin
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NET Core 5.0 introduced a wonderful change of the moniker from
netcoreapp5.0tonet5.0because of that, one of our conditions:
BenchmarkDotNet/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliGenerator.cs
Line 29 in 3223c94
was not detecting the correct platform and causing #1477
cc @JamesNK